Webtest doesn't parse quoted cookies

[mgood]

Included test case & fix:

(a) /dev/null vs. (b) b/tests/test_cookies.py

@@ +1 @@
+import webtest
+from nose.tools import eq_
+
+
+def cookie_app(environ, start_response):
+    status = '200 OK'
+    body = ''
+    headers = [
+        ('Content-Type', 'text/html'),
+        ('Content-Length', str(len(body))),
+        ('Set-Cookie', 'spam=eggs'),
+        ('Set-Cookie', 'foo="bar;baz"'),
+    ]
+    start_response(status, headers)
+    return [body]
+
+
+def test_cookies():
+    app = webtest.TestApp(cookie_app)
+    assert not app.cookies, 'App should initially contain no cookies'
+
+    res = app.get('/')
+    assert app.cookies, 'Response should have set cookies'
+    eq_(app.cookies['spam'], 'eggs')
+    eq_(app.cookies['foo'], 'bar;baz')

webtest/__init__.py

@@ -14 +14 @@
 import time
 import cgi
 import os
-from Cookie import BaseCookie, CookieError
+from Cookie import SimpleCookie, CookieError
 from Cookie import _quote as cookie_quote
 try:
     from cStringIO import StringIO
@@ -374 +374 @@
         res.cookies_set = {}
         for header in res.headers.getall('set-cookie'):
             try:
-                c = BaseCookie(header)
+                c = SimpleCookie(header)
             except CookieError, e:
                 raise CookieError(
                     "Could not parse cookie header %r: %s" % (header, e))

[dound]

Line 342 also needs to be updated, or the value ends up being double quoted when sent back to the server:

@@ -339,7 +339,7 @@
         req.environ['wsgi.errors'] = errors
         if self.cookies:
             cookie_header = ''.join([
-                '%s="%s"; ' % (name, cookie_quote(value))
+                '%s=%s; ' % (name, cookie_quote(value))
                 for name, value in self.cookies.items()])
             req.environ['HTTP_COOKIE'] = cookie_header
         req.environ['paste.testing'] = True

[peter_v]

I can confirm that this is a bug. It seems that Cookie._quote imported as cookie_quote already adds quotes if needed so hard coding additional quotes here seems wrong.

[ianb]

Applied in 107:ded87c86cd00