Ticket #189 (closed enhancement: fixed)

Opened 5 years ago

Last modified 18 months ago

Paste shouldn't raise exception on invalid cookies

Reported by: max Owned by: ianb
Priority: normal Milestone: 1.3
Component: paste Version: released-version
Severity: normal Keywords:
Cc: ischenko@…, nozom.kaneko@…

Description

If the cookie's content is invalid the underlying Cookie library will raise CookieError? when trying to load the cookie which is currently simply propagated by Paste.

Paste should catch it and do something meaningful.

See  this thread for example.

Attachments

add-cookie-test.diff Download (447 bytes) - added by knzm 20 months ago.
fix-cookie-error.diff Download (1.0 KB) - added by knzm 20 months ago.

Change History

Changed 4 years ago by ianb

  • status changed from new to closed
  • resolution set to fixed

This seems to work fine now; tests/test_request.py contains a test for bad cookies, that passes fine.

Changed 20 months ago by knzm

  • status changed from closed to reopened
  • cc nozom.kaneko@… added
  • resolution fixed deleted

I encountered similar issue a few days ago and I investigated it. Please see the attachments for detail.

Version: 1.7.1

Changed 20 months ago by knzm

Changed 20 months ago by knzm

Changed 18 months ago by ianb

  • status changed from reopened to closed
  • resolution set to fixed

Applied in 1481:1592b7b9d6b2

Note: See TracTickets for help on using tickets.