Ticket #18 (closed enhancement: fixed)

Opened 7 years ago

Last modified 3 years ago

[PATCH] Fixes for PathDispatch and the unpack decorator in wareweb

Reported by: thomas.jenkins@… Owned by: ianb
Priority: highest Milestone: 1.4.1
Component: documentation Version: svn-trunk
Severity: critical Keywords: rHzUctNvm
Cc:

Description

PathDispatch? dispatcher needed a simple typo fix (== vs. =).

I'm less sure about the unpack fixes. It didn't seem to working at all and wasn't used in any examples. I'm definately not clear about the vision of the coersion framework but it works in the case I have at hand.

I also removed the copying of the fields dictionary in FunctionArgSpec?.unpack_args not only because it was throwing an error but because I did not see it altered any where in the function body.

Hope this is of some use.

Attachments

pathdispatch-unpack-fixes.patch Download (4.7 KB) - added by thomas.jenkins@… 7 years ago.
Patch for fixes in wareweb/dispatch.py and wareweb/packing.py
dispatch-typos.patch Download (1.4 KB) - added by thomas.jenkins@… 7 years ago.
Typo fixes for wareweb/dispatch.py
packing-fixes.patch Download (3.8 KB) - added by thomas.jenkins@… 7 years ago.
Make unpack decorator for PatchDispatch? work.

Change History

Changed 7 years ago by thomas.jenkins@…

Patch for fixes in wareweb/dispatch.py and wareweb/packing.py

Changed 7 years ago by thomas.jenkins@…

After finding some more typos in dispatch.py I split the patch into the (I think) obviously correct typo fixes for dispatch.py (dispatch-typos.patch) and the potentially incorrect fixes for packing.py (packing-fixes.patch).

Changed 7 years ago by thomas.jenkins@…

Typo fixes for wareweb/dispatch.py

Changed 7 years ago by thomas.jenkins@…

Make unpack decorator for PatchDispatch? work.

Changed 7 years ago by ianb

  • priority changed from normal to lowest
  • status changed from new to assigned
  • severity changed from normal to minor

I applied the patch to dispatch.py (r2683), but most of the changes to packing.py seemed incorrect to me, I'll have to look at them more closely.

Changed 7 years ago by thomas.jenkins@…

Just wanted to point out that I think there were some typos missed in dispatch.py. httpexceptions.Forbidden is used instead of httpexceptions.HTTPForbidden. Just in case you missed them.

Changed 6 years ago by ianb@…

  • cc thomas.jenkins@… removed
  • status changed from assigned to closed
  • resolution set to fixed

This code has had some reworking since this; I think any issues would have worked themselves out by now.

Changed 6 years ago by anonymous

  • severity changed from minor to critical
  • component changed from *paste to documentation
  • priority changed from lowest to highest
  • version svn-trunk deleted
  • milestone set to 0.4
  • type changed from defect to enhancement

 software testing resource and tool  police scanner frequency minnesota  car services transport  indoor wedding ceremonies  pussy cat doll official site  various artist chillout relax jazz tidepools afromystik  der kleine herr friedemann thomas mann  business own site start web  from greece in nasa photo satellite  keyboard korg triton  car haulers sale used  risks of information security  soundtracks movies time of the season the zombies  gardening hand regular tool  belkin firewall security log  painted flower pot  www ke musik dk  ÑÐ¿Ñ€Ð°Ð²Ð¾Ñ‡Ð½Ð¸Ðº мебели  profile tax software  bracelet citizen sizing watch pioneer dvd recorder player  company hosting memphis site web  baby bug bunny cartoon  caribbean radio station on the internet  love hina pc  canada news channel  multiplayer omaha poker  wedding favor quote  picture britney spears kevin  adult group groups.msn.com msn site story  herbalife beauty skin care product  computer background scenery  sparkasse hamburg immobilien  celebrity free sex story  haus frauen sex  chip poker set wpt  canon pixma ip6000d photo printer  migente music code  oklahoma sex offender list  bali blind shades  computer storage product  ultrasound boy or girl quiz  bingo game play  center hp printer service  black ebony porn  accessory dvd portable samsung  various artist soft self shame  employment law in canada  1996 suzuki esteem  computer mini portable

Changed 6 years ago by anonymous

Great resource. Really helpful for understand odbc things.

Thanks.

my email:googlefans@163.com

=============Some my site====================

1. wow gold

2. world of warcraft gold

3. wow gold

Changed 5 years ago by anonymous

  • milestone 0.4 deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.